[#2429] Allow different time period for different repos in report-config.yaml #2490

lihongong · 2025-07-28T07:16:51Z

Proposed commit message

Add since and until field in report-config.yaml under branches

Previously, the report-config.yaml doesn't support different time periods for 
different repos and relied on CLI flags for all repos.

Add two optional fields (since, until) with the format
- dd/MM/yyyy
- dd/MM/yyyy HH:mm
- dd/MM/yyyy HH:mm:ss

report-config.yaml input:

Portfolio Mode:

Normal Mode:

This help parsing different date time inputs formats.

New log message is added in ReportBranchData to show invalid date format entered by user. Branch

Also add checking of since date before until date in OneStopConfig

…ConfigYaml' into branch-diffirentTimePeriodReportConfigYaml

Accidentally commit changes to report-config.yaml when working with new report-config feature.

lihongong · 2025-08-27T17:44:55Z

Sorry for the late reply.

what happens when both CLI dates are provided but only one config date is set?

It will use the config date provided and fall back to the cli date for the other that isn't specified in the config file.
Example:
config: since = 1/2/2025
cli: since = 1/1/2025, until = 31/4/2025
effective: since = 1/2/2025, until = 31/4/2025
This behavior is handled in OneStopConfigRunConfiguration

github-actions · 2025-09-27T00:21:59Z

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

github-actions · 2025-11-02T00:26:13Z

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

github-actions · 2025-11-09T00:26:24Z

This PR was closed because it has been marked as stale for 7 days with no activity.
Feel free to reopen this PR if you would like to continue working on it.

lyuanww

@lihongong Sorry for the late review. The PR looks good overall—just a few small nits around documentation and tests before I can approve. Good work!

lyuanww · 2025-12-06T10:16:13Z

docs/ug/reportConfig.md

+        * `since`: Start date of commits to include in the analysis. Accepted formats:
+          * Date only
+            * `dd/MM/yyyy`
+          * Date and time
+            * `dd/MM/yyyy HH:mm` or
+            * `dd/MM/yyyy HH:mm:ss`
+
+        * `until`: End date of commits to include in the analysis. Accepted formats:
+          * **same as the above**


Suggested change

* `since`: Start date of commits to include in the analysis. Accepted formats:

* Date only

* `dd/MM/yyyy`

* Date and time

* `dd/MM/yyyy HH:mm` or

* `dd/MM/yyyy HH:mm:ss`

* `until`: End date of commits to include in the analysis. Accepted formats:

* **same as the above**

* `since`: Start date of commits to include in the analysis. Accepted formats:

* Date format:

* `dd/MM/yyyy`

* Date and time formats:

* `dd/MM/yyyy HH:mm`

* `dd/MM/yyyy HH:mm:ss` (e.g., `05/12/2025 14:32:10`)

* `until`: End date of commits to include in the analysis. Accepted formats:

* Date format:

* `dd/MM/yyyy`

* Date and time formats:

* `dd/MM/yyyy HH:mm`

* `dd/MM/yyyy HH:mm:ss` (e.g., `05/12/2025 14:32:10`)

Perhaps this is clearer?

lyuanww · 2025-12-06T17:46:36Z

docs/ug/reportConfig.md

+Behavior When Both Report Config Dates & CLI Flags Are Provided:
+
+- If `since` date is specified in both `report-config.yaml` and CLI, the **Config dates take precedence** for that repository. The same applies to `until` date.
+- The Config date range must fall within the **CLI date boundaries**. If it exceeds, the program exits with an error.
+    - Example:
+        - CLI Date - Since: 10/10/2024, Until: 20/10/2024
+        - Valid Config Date - Since: 11/10/2024, Until: 19/10/2024
+        - Invalid Config Date - Since: 9/10/2024, Until: 21/10/2024
+- If only one of the CLI flags is provided, the Config dates will not be restricted by the missing CLI flag.
+- If Config dates are missing, the CLI flags are used.
+- If neither Config nor CLI provides dates, default date ranges are used.


Suggested change

Behavior When Both Report Config Dates & CLI Flags Are Provided:

- If `since` date is specified in both `report-config.yaml` and CLI, the **Config dates take precedence** for that repository. The same applies to `until` date.

- The Config date range must fall within the **CLI date boundaries**. If it exceeds, the program exits with an error.

- Example:

- CLI Date - Since: 10/10/2024, Until: 20/10/2024

- Valid Config Date - Since: 11/10/2024, Until: 19/10/2024

- Invalid Config Date - Since: 9/10/2024, Until: 21/10/2024

- If only one of the CLI flags is provided, the Config dates will not be restricted by the missing CLI flag.

- If Config dates are missing, the CLI flags are used.

- If neither Config nor CLI provides dates, default date ranges are used.

**Behavior of `since`/`until` in report-config.yaml vs. `--since`/`--until` in CLI**

* If `since` date is specified in both `report-config.yaml` and CLI, the config date takes priority for that repository. The same rule applies to the `until` date.

* Config date range must fall **within** the CLI date range; otherwise the program exits with an error.

* Example with CLI `--since` = 10/10/2024, `--until` = 20/10/2024:

* Valid config dates: `since` = 11/10/2024, `until` = 19/10/2024

* Invalid config dates: `since` = 9/10/2024, `until` = 21/10/2024

* If only one CLI flag is provided, the missing CLI value does not restrict config dates.

* If config dates are missing, CLI values are used.

* If neither provides dates, default ranges are applied.

Perhaps this is clearer?

lyuanww · 2025-12-06T17:48:05Z

src/main/java/reposense/model/OneStopConfigRunConfiguration.java

    private static final Logger logger = LogsManager.getLogger(OneStopConfigRunConfiguration.class);
+    private static final String MESSAGE_CLI_CONFIG_DATE_CONFLICT =
+            "You specified in CLI a date range of --since to --until, "
+            + "but your report config specifies a date range that extends outside --SINCE or --UNTIL. "


Suggested change

+ "but your report config specifies a date range that extends outside --SINCE or --UNTIL. "

+ "but your report config specifies a date range that extends outside --since or --until. "

lyuanww · 2025-12-07T05:15:00Z

src/test/java/reposense/model/OneStopConfigRunConfigurationTest.java

+
        ReportBranchData branch = new ReportBranchData("master", "My project", authorList,
-                ignoreGlobList, ignoreAuthorList, 2000000L);
+                ignoreGlobList, ignoreAuthorList, 2000000L, sinceDate, untilDate);


Could you also add the values for expectedRepoConfigurations?

lyuanww · 2025-12-07T05:22:10Z

src/test/java/reposense/model/reportconfig/ReportBranchDataTest.java

+        String untilDateStr = "30/5/2025";

-        ReportBranchData data = new ReportBranchData(branch, blurb, authors, ignoreGlobs, ignoreAuthors, fileSize);
+        ReportBranchData data = new ReportBranchData(branch, blurb, authors, ignoreGlobs, ignoreAuthors, fileSize,


Maybe you should add the assert for the new fields as well?

lyuanww · 2025-12-09T17:07:33Z

src/main/java/reposense/model/OneStopConfigRunConfiguration.java

+            // if both since and until date are provided in cli, then we need to check whether config date lays between
+            // the time period
+            if (configDate.isBefore(cliSinceDate) || configDate.isAfter(cliUntilDate)) {
+                throw new InvalidDatesException(MESSAGE_CLI_CONFIG_DATE_CONFLICT);


Can you help to edit the comment description of InvalidDatesException.java?

lihongong added 9 commits July 27, 2025 23:48

Add LocalDateTimeParser.java

936e150

This help parsing different date time inputs formats.

Add since and until date in ReportBranchData.java

0c3c3bb

New log message is added in ReportBranchData to show invalid date format entered by user. Branch

Refactor and improve readability

61fc135

Undo unwanted changes

e7b2a34

Update test cases for classes related to ReportBranchData

348a285

Also add checking of since date before until date in OneStopConfig

Add test cases for LocalDateTimeParser

0185563

Update reportConfig.md for different time period for repos

4e3b0e2

Touch up

bed5407

Remove wrongly commited file

4f2c8c4

github-actions bot requested a deployment to dashboard-2490 July 28, 2025 07:17 Abandoned

github-actions bot requested a deployment to docs-2490 July 28, 2025 07:17 Abandoned

Merge branch 'master' into branch-diffirentTimePeriodReportConfigYaml

83ff5e7

github-actions bot requested a deployment to dashboard-2490 July 28, 2025 07:22 Abandoned

github-actions bot requested a deployment to docs-2490 July 28, 2025 07:22 Abandoned

lihongong added 3 commits July 28, 2025 22:15

Restore logo.png

8093088

no message

55ecb25

Merge remote-tracking branch 'origin/branch-diffirentTimePeriodReport…

8d345bd

…ConfigYaml' into branch-diffirentTimePeriodReportConfigYaml

github-actions bot requested a deployment to dashboard-2490 July 28, 2025 16:50 Abandoned

github-actions bot requested a deployment to docs-2490 July 28, 2025 16:50 Abandoned

lihongong added 2 commits July 29, 2025 01:13

Restore original report-config and remove unused imports

fff0f1e

Accidentally commit changes to report-config.yaml when working with new report-config feature.

Restore original report-config

553b1a2

Accidentally commit changes to report-config.yaml when working with new report-config feature.

github-actions bot requested a deployment to dashboard-2490 July 28, 2025 17:19 Abandoned

github-actions bot requested a deployment to docs-2490 July 28, 2025 17:19 Abandoned

Restore original report-config

83811ee

Accidentally commit changes to report-config.yaml when working with new report-config feature.

github-actions bot requested a deployment to dashboard-2490 July 28, 2025 17:20 Abandoned

github-actions bot requested a deployment to docs-2490 July 28, 2025 17:20 Abandoned

lihongong changed the title ~~Branch diffirent time period report config yaml~~ Allow diffirent time period for different repos in report-config.yaml Jul 28, 2025

Restore report-config.yaml

988eb5a

github-actions bot requested a deployment to dashboard-2490 July 29, 2025 14:35 Abandoned

github-actions bot requested a deployment to docs-2490 July 29, 2025 14:35 Abandoned

Fix incorrect date format

e7eabb0

github-actions bot requested a deployment to dashboard-2490 August 27, 2025 16:52 Abandoned

github-actions bot requested a deployment to docs-2490 August 27, 2025 16:52 Abandoned

Fix test case failure due to incorrect reference data

b64571f

github-actions bot requested a deployment to dashboard-2490 August 27, 2025 17:04 Abandoned

github-actions bot requested a deployment to docs-2490 August 27, 2025 17:04 Abandoned

Fix checkstyle issue

5041dc2

github-actions bot requested a deployment to dashboard-2490 August 27, 2025 17:19 Abandoned

github-actions bot requested a deployment to docs-2490 August 27, 2025 17:19 Abandoned

Fix trailing whitespace

2439bdc

github-actions bot temporarily deployed to dashboard-2490 August 27, 2025 17:24 Inactive

github-actions bot temporarily deployed to docs-2490 August 27, 2025 17:24 Inactive

github-actions bot added the Stale label Sep 27, 2025

CYX22222003 removed the Stale label Oct 2, 2025

Merge branch 'master' into branch-diffirentTimePeriodReportConfigYaml

cf68709

github-actions bot requested a deployment to dashboard-2490 October 2, 2025 12:57 Abandoned

github-actions bot requested a deployment to docs-2490 October 2, 2025 12:57 Abandoned

CYX22222003 added the s.Ongoing label Oct 2, 2025

CYX22222003 changed the title ~~Allow different time period for different repos in report-config.yaml~~ [#2429] Allow different time period for different repos in report-config.yaml Oct 2, 2025

github-actions bot added the Stale label Nov 2, 2025

github-actions bot closed this Nov 9, 2025

lyuanww reopened this Dec 6, 2025

github-actions bot deployed to dashboard-2490 December 6, 2025 10:06 View deployment

github-actions bot deployed to docs-2490 December 6, 2025 10:06 View deployment

lyuanww requested changes Dec 9, 2025

View reviewed changes

CYX22222003 removed the Stale label Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[#2429] Allow different time period for different repos in report-config.yaml #2490

[#2429] Allow different time period for different repos in report-config.yaml #2490

Uh oh!

lihongong commented Jul 28, 2025

Uh oh!

lihongong commented Aug 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

lyuanww left a comment

Uh oh!

lyuanww Dec 6, 2025

Uh oh!

lyuanww Dec 6, 2025

Uh oh!

lyuanww Dec 6, 2025

Uh oh!

lyuanww Dec 7, 2025

Uh oh!

lyuanww Dec 7, 2025

Uh oh!

lyuanww Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	+ "but your report config specifies a date range that extends outside --SINCE or --UNTIL. "
	+ "but your report config specifies a date range that extends outside --since or --until. "

[#2429] Allow different time period for different repos in report-config.yaml #2490

Are you sure you want to change the base?

[#2429] Allow different time period for different repos in report-config.yaml #2490

Uh oh!

Conversation

lihongong commented Jul 28, 2025

Proposed commit message

Uh oh!

lihongong commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

lyuanww left a comment

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

lyuanww Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lihongong commented Aug 27, 2025 •

edited

Loading