Skip to content

Conversation

@CYX22222003
Copy link
Member

@CYX22222003 CYX22222003 commented Feb 10, 2025

Fix reposense/RepoSense#2285

Proposed commit message

Add post-deployment test

Currently, deployments need to be tested manually, which can open
room
for errors in deployment in production

Let's use Lighthouse CI to audit the deployed web page. 

Other information

Information about lighthouse CI action:
https://github.com/treosh/lighthouse-ci-action

Sample test log:
https://github.com/CYX22222003/RepoSense-user-experiment-cyx/actions/runs/13253442029/job/36995960904
https://github.com/CYX22222003/RepoSense-user-experiment-cyx/actions/runs/13256746216/job/37004806285

@CYX22222003 CYX22222003 changed the title Deployment test [#2285] Add post-deployment test actions Feb 11, 2025
@CYX22222003 CYX22222003 marked this pull request as ready for review February 11, 2025 00:49
@CYX22222003 CYX22222003 requested review from gok99 and sopa301 February 11, 2025 00:49
@sopa301
Copy link
Contributor

sopa301 commented Feb 11, 2025

Thanks for looking into a solution for this! However, this seems to run on the publish-RepoSense CI. We should add it to the main RepoSense CI instead (because we want it to run on RepoSense PRs to ensure that publish-RepoSense works before merging on RepoSense).

@CYX22222003
Copy link
Member Author

CYX22222003 commented Feb 11, 2025

Thanks for looking into a solution for this! However, this seems to run on the publish-RepoSense CI. We should add it to the main RepoSense CI instead (because we want it to run on RepoSense PRs to ensure that publish-RepoSense works before merging on RepoSense).

Just want to clarify, so what the issue is referring to is actually a post deployment test on the previewed website of each PR to the main RepoSense repository?

In addition, I also notice that our previewed webpage is built using surge which seems to be not so reliable. Will this potentially affect the post-deployment test?

@sopa301
Copy link
Contributor

sopa301 commented Feb 11, 2025

Basically, we're trying to test if a publish-RepoSense deployment of the branch of the main RepoSense works. It's a pre-merge check on each RepoSense PR that deploys via Github Actions (like how publish-RepoSense does), then checks that deployment to make sure it works.

Surge should not affect the test because we are testing the Github Actions deployment of the RepoSense PR.

@CYX22222003
Copy link
Member Author

Basically, we're trying to test if a publish-RepoSense deployment of the branch of the main RepoSense works. It's a pre-merge check on each RepoSense PR that deploys via Github Actions (like how publish-RepoSense does), then checks that deployment to make sure it works.

Surge should not affect the test because we are testing the Github Actions deployment of the RepoSense PR.

OK, i will look at the relevant deployment script in the main repo and make modification there.

i would like to keep this PR alive for now.

@CYX22222003 CYX22222003 marked this pull request as draft February 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a way to test publish-RepoSense deployment pipeline

2 participants