fix(bootstrap): Handle malformed BOOTSTRAP values#927
Open
direkkakkar319-ops wants to merge 2 commits into
Open
fix(bootstrap): Handle malformed BOOTSTRAP values#927direkkakkar319-ops wants to merge 2 commits into
BOOTSTRAP values#927direkkakkar319-ops wants to merge 2 commits into
Conversation
…ression test` Signed-off-by: Direk Kakkar <millioniar1717@gmail.com>
Author
|
Hi, @kairoaraujo thius PR addeds a defensive fallback in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bootstrap edge case where unexpected
Redis BOOTSTRAPstring formats could causebootstrap_state()toreturn Noneand crash callers withAttributeError.Addeed a fallback else branch that returns a safe default and logs a warning
Also adds a unit test covering a malformed 3-segment bootstrap value.
tests cases pass

linting passes

impact
A corrupted or unexpected Redis value brings down the
API entirely — a silentDoSon the bootstrap machinery. All endpoints that callbootstrap_state()are affected.testing
test ran fro confirming the fix
output
Types of changes
Additional requirements
Use of AI
Code of Conduct