Reconcile As-Built Reconciliation reminder with shipped features - #138
Merged
Conversation
Rename change-annotations (#70/#133) and Inlay Hints (F23, #43/#57/#77) have both shipped, but this reminder's checklist was still 100% unchecked and its status table still called both "Draft — not yet implemented". Fixes the InlayHints plan doc's own stale status header too. Filed #134-#137 to track the actual canonical-doc reconciliation work (Feature-Designs, Architecture, Overview, Open-Questions) rather than doing it inline here, since it's substantial content work best tracked as its own backlog. Checklist items now link to their tracking issue. Checked off the two §5 memory items that were completed directly during this review (no repo PR needed for those).
Resolves conflict on the shipped-features status table (master had independently marked Rename change-annotations as implemented via #133, without the issue links/reconciliation tracking this PR adds). Also updates the Architecture checklist item to note the StepRenameHandler decomposition from #139/#140, which landed on master after this branch was cut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/AsBuilt-Reconciliation-Reminder.md's checklist was still 100% unchecked and its status table still called both "Draft — not yet implemented".docs/InlayHints-Implementation-Plan.md's own stale status header ("Draft for review" despite being fully implemented and shipped a while ago).LSP-IDE-Support-Feature-Designs.md/Architecture.md/Overview.md/Open-Questions.md) rather than doing that substantial content work inline in this PR. Checklist items now link to their tracking issue.Test plan