Skip to content

Show colliding step bindings when hovering an ambiguous step #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clrudolphi merged 1 commit into from
Jul 4, 2026
Merged

Show colliding step bindings when hovering an ambiguous step #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/LSP/Reqnroll.IdeSupport.LSP.Core/Diagnostics/DiagnosticsAggregator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@ public IReadOnlyList<GherkinDiagnostic> Aggregate(
BindingSource));
}

// Ambiguous matches reported as errors
// Ambiguous matches reported as errors. Result.GetErrorMessage() lists every matching
// binding (MatchResult.CreateMultiMatch builds it for exactly this case), so hovering
// shows which step definitions collide instead of just "it's ambiguous".
foreach (var step in matchSet.Ambiguous)
{
diagnostics.Add(new GherkinDiagnostic(
AmbiguousStepMessage,
step.Result.GetErrorMessage() ?? AmbiguousStepMessage,
step.Range,
GherkinDiagnosticSeverity.Error,
BindingSource));
Expand Down
3 changes: 2 additions & 1 deletion tests/LSP/Reqnroll.IdeSupport.LSP.Core.Tests/Diagnostics/DiagnosticsAggregatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ public void Ambiguous_step_produces_Error_diagnostic_with_correct_message_and_so
var diag = result[0];
diag.Severity.Should().Be(GherkinDiagnosticSeverity.Error);
diag.Source.Should().Be(DiagnosticsAggregator.BindingSource);
diag.Message.Should().Be("Ambiguous step definition.");
diag.Message.Should().Contain("Method1", "the hover message should list every colliding binding, not just say it's ambiguous");
diag.Message.Should().Contain("Method2");
}

[Fact]
Expand Down
Loading