-
Notifications
You must be signed in to change notification settings - Fork 10
Feature generate async snippets from 'DefineSteps' command #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the reqnroll.json file when generating snippets (sync or async). Added unit tests for the new skeletonStyle enum deserialization. Added unit test for the SnippetService. Added Spec test in the DefineStepsCommand spec for the generation of async and sync snippets.
|
I like to test and review this, but I have hard time to test this. Are there some (easy) steps to follow? |
I think it is just
|
|
Thanks, but to be more clear, I mean using this branch. With the experimental VS instance most of the time the plugin isn't installed when debugging/running this branch from VS2022 (Haven't tested VS2026). Or sometimes an old version is hanging (and that's hard to see) Another option is to install it manually but that is cumbersome (multiple restarts VS) and not possible to debug then? (Or could I attach to a process?) |
For me the exp hive support from VS2022 was working in a quite stable way. This is my daily routine:
In very rare cases, the exp hive gets corrupted. In this case what I do:
I hope this helps. |
|
OK I got something working now after some restarts. And I get it working, but only this way:
{
"$schema": "https://schemas.reqnroll.net/reqnroll-config-latest.json",
"trace": {
// "stepDefinitionSkeletonStyle": "AsyncCucumberExpressionAttribute"
}
}
{
"$schema": "https://schemas.reqnroll.net/reqnroll-config-latest.json",
"trace": {
"stepDefinitionSkeletonStyle": "AsyncCucumberExpressionAttribute"
}
}
now this works, but if I change the code with this config, I get the error maybe first something should be changed in the reqnroll project itself? |
|
@304NotModified Oh. The problem is with the PR, I fear. Let me ckeck. |
gasparnagy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this and it worked for me.
@304NotModified I think in your case the problem was that the sample project that you have tested it with was with a Reqnroll version that did not support this enum value. It should only work with v3.2.0 or later

This PR replaces part of #121.
🤔 What's changed?
Modified the SnippetsService to generate asynchronous step bindings based upon the StepDefinitionSkeletonStyle setting in the reqnroll.json configuration file.
This PR does NOT include any UI modifications. The behavior is driven solely by the configuration file.
⚡️ What's your motivation?
To ease the developer transition to async step binding methods.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Anything?
📋 Checklist: