Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@
<PackageReference Include="dnlib" Version="4.4.0" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.1" />
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0
See detailed explanation in Reqnroll.VisualStudio.ReqnrollConnector.V1.csproj

For Generic connector (net6.0+), this assembly should already be available via CopyLocalLockFileAssemblies,
but adding explicit reference ensures consistency across all connector versions and makes the dependency clear.
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,30 @@
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Reqnroll.CustomPlugin" Version="1.0.0" />
<PackageReference Include="MSTest.TestFramework" Version="3.6.0" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0

INVESTIGATION FINDINGS:
- User projects using Reqnroll.Microsoft.Extensions.DependencyInjection plugin (v2.0+)
depend on Microsoft.Extensions.DependencyInjection v6.0.0
- This transitively requires Microsoft.Extensions.DependencyInjection.Abstractions v6.0.0
- When the V1 connector (net48) analyzes user projects, it needs to load this assembly
- The DLL was missing from VSIX, causing FileNotFoundException in production

SOLUTION (Option A - PREFERRED):
- Using v8.0.0 instead of v6.0.0 for better forward compatibility
- v8.0.0 is backward compatible with code targeting v6.0.0 (stable API contract)
- Better alignment with .NET 6/7/8/9 used by Generic connector
- Lower risk of conflicts with VS 2022/2025 built-in components
- The assembly is included in VSIX via DeploymentAssets.props (copies all connector outputs)

VERIFICATION:
- After build, check Connectors/bin/Release/Reqnroll-V1/ contains Microsoft.Extensions.DependencyInjection.Abstractions.dll
- Extract VSIX (it's a ZIP) and verify Connectors/Reqnroll-V1/ contains the DLL
- Version should be 8.0.0.0 (check properties or use: dumpbin /headers Microsoft.Extensions.DependencyInjection.Abstractions.dll)
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.1" />
<PackageReference Include="SpecFlow.CustomPlugin" Version="3.9.40" />
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0
See detailed explanation in Reqnroll.VisualStudio.ReqnrollConnector.V1.csproj
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="SpecFlow.CustomPlugin" Version="3.9.40" />
<PackageReference Include="MSTest.TestFramework" Version="3.6.0" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0

For SpecFlow projects using SolidToken.SpecFlow.DependencyInjection plugin (v3.1+ uses DI v3.1.0, v4.0+ uses DI v6.0.0)
Same issue as Reqnroll connector - see detailed explanation in Reqnroll.VisualStudio.ReqnrollConnector.V1.csproj
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.1" />
<ProjectReference Include="..\SpecFlow.VisualStudio.SpecFlowConnector.Models\SpecFlow.VisualStudio.SpecFlowConnector.Models.csproj" />
<PackageReference Include="SpecFlow.CustomPlugin" Version="3.9.40" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0
See detailed explanation in Reqnroll.VisualStudio.ReqnrollConnector.V1.csproj
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<Import Project="..\SpecFlow.VisualStudio.Common\SpecFlow.VisualStudio.Common.projitems" Label="Shared" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.1" />
<PackageReference Include="SpecFlow.CustomPlugin" Version="3.9.40" />

<!--
Microsoft.Extensions.DependencyInjection.Abstractions v8.0.0
See detailed explanation in Reqnroll.VisualStudio.ReqnrollConnector.V1.csproj
-->
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading