Fix CustomPlugin and SpecflowCompatiblity.ReqnrollPlugin builds by adjusting pack#1058
Merged
Conversation
clrudolphi
reviewed
Mar 13, 2026
Contributor
|
And what caused nuget packing to fail for those two plugins, now, compared to what we've been doing since the packing approach was (recently) updated? It seems like this came out of nowhere. |
Contributor
Author
I have no idea. I could reproduce it locally and fixed it (for my pc). It also looks like it doesn't happen all the time (some CI builds run, some fail). |
Contributor
|
@obligaron What should we do? Are we confident to merge this or do you want to make further analysis? |
Contributor
Author
|
It fixes compilation issues in CI and locally. The nuget packages look the same (to me). I would merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
IncludeBuildOutputto avoid processing empty BuildOutput.⚡️ What's your motivation?
Fixes #1057
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I checked that the generated nuget packages have the same content as the last published in nuget but it would be good if someone else looks again.
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.