Skip to content

Fix CustomPlugin and SpecflowCompatiblity.ReqnrollPlugin builds by adjusting pack#1058

Merged
gasparnagy merged 3 commits into
mainfrom
fix/buildproblem
Mar 23, 2026
Merged

Fix CustomPlugin and SpecflowCompatiblity.ReqnrollPlugin builds by adjusting pack#1058
gasparnagy merged 3 commits into
mainfrom
fix/buildproblem

Conversation

@obligaron

Copy link
Copy Markdown
Contributor

🤔 What's changed?

  • Reqnroll.CustomPlugin uses IncludeBuildOutput to avoid processing empty BuildOutput.
  • Reqnroll.SpecFlowCompatibility.ReqnrollPlugin sets IsPackable to false, because it's included in Reqnroll.SpecFlowCompatibility (part of lib nuget folder)

⚡️ What's your motivation?

Fixes #1057

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I checked that the generated nuget packages have the same content as the last published in nuget but it would be good if someone else looks again.


This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Comment thread .github/workflows/ci.yml
@clrudolphi

Copy link
Copy Markdown
Contributor

And what caused nuget packing to fail for those two plugins, now, compared to what we've been doing since the packing approach was (recently) updated? It seems like this came out of nowhere.

@obligaron

Copy link
Copy Markdown
Contributor Author

And what caused nuget packing to fail for those two plugins, now, compared to what we've been doing since the packing approach was (recently) updated? It seems like this came out of nowhere.

I have no idea. I could reproduce it locally and fixed it (for my pc). It also looks like it doesn't happen all the time (some CI builds run, some fail).

@gasparnagy

Copy link
Copy Markdown
Contributor

@obligaron What should we do? Are we confident to merge this or do you want to make further analysis?

@obligaron

Copy link
Copy Markdown
Contributor Author

It fixes compilation issues in CI and locally. The nuget packages look the same (to me). I would merge this.

@gasparnagy gasparnagy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@gasparnagy gasparnagy merged commit bdf5615 into main Mar 23, 2026
8 checks passed
@gasparnagy gasparnagy deleted the fix/buildproblem branch March 23, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reqnroll Build Fails when Packaging CustomPlugin and SpecFlowCompatibilityPlugin

4 participants