removes older versions of python. #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pquentin I went ahead and dropped older versions of Python and fixed the tests. |
pquentin
requested changes
Oct 24, 2022
Contributor
There was a problem hiding this comment.
Thanks! Can you please:
- Remove the Python 2 related code in
requests/_compat.py? - Grep for
Python 2andsys.version_infoand see what can be removed? - Run the test suite with Python 2 and Python 3 with coverage to see if you have missed anything? (We could even work on having a coverage check in GitHub first: https://hynek.me/articles/ditch-codecov-python/)
Author
|
@pquentin I'll wait till your PR you are working on is finished so we don't get merge conflicts. |
hugovk
reviewed
Nov 6, 2022
| 'Programming Language :: Python', | ||
| 'Programming Language :: Python :: 2', | ||
| 'Programming Language :: Python :: 2.7', | ||
| 'Programming Language :: Python :: 3', |
Contributor
There was a problem hiding this comment.
This can stay, and can also add:
'Programming Language :: Python :: 3 :: Only'| package_data={'': ['LICENSE', 'AUTHORS.rst']}, | ||
| include_package_data=True, | ||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*', | ||
| python_requires='>=3.7, <3.11', |
Contributor
There was a problem hiding this comment.
Don't add an upper limit:
Suggested change
| python_requires='>=3.7, <3.11', | |
| python_requires='>=3.7', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes earlier versions of python. Drops support for Python 2.7 and Python <3.7