Skip to content

Refactor CI workflow and Google Analytics component #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
area73 merged 2 commits into from
Jan 6, 2026
Merged

Refactor CI workflow and Google Analytics component #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a23d2
Refactor CI workflow and Google Analytics component
cofo-rerades Jan 6, 2026
5a09cd2
Merge branch 'master' into env-var-ga
area73 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ jobs:
E2E-Tests:
name: E2E-Tests
runs-on: ubuntu-latest
# env:
# PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand All @@ -83,7 +85,7 @@ jobs:
PORT: 4321
HOST: 0.0.0.0
BASE_URL: http://127.0.0.1:4321
PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
# PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
Copy link
Copy Markdown

@cursor cursor bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual-Regression-Tests will always fail due to validation check

High Severity

The PUBLIC_GA_MEASUREMENT_ID environment variable is commented out at line 88, but lines 97-103 still contain a validation step that checks if this variable is set and exits with error code 1 if empty. Since the variable is no longer set, the validation will always fail, causing the Visual-Regression-Tests job to fail every time it runs.

Fix in Cursor Fix in Web

steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
Expand Down
1 change: 0 additions & 1 deletion src/components/GoogleAnalytics.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ const gaMeasurementId = import.meta.env.PUBLIC_GA_MEASUREMENT_ID;
<>
{/* Google Analytics 4 - Optimized non-blocking implementation */}
{/* Script loads asynchronously with low priority to not compete with critical resources */}
{/* @ts-expect-error - fetchpriority is valid HTML but not yet in TypeScript definitions */}
<script
async
src={`https://www.googletagmanager.com/gtag/js?id=${gaMeasurementId}`}
Expand Down
Loading