Fix scroll_to_row not taking the header into account#44
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the scroll_to_row functionality was not properly accounting for the sticky header, causing rows to be scrolled to positions that were hidden behind the header. The fix simplifies the scrolling logic and ensures scrolled content appears visible below the sticky regions.
Changes:
- Simplified the
x_from_column_nrandy_from_row_nrclosures by removing incorrect conditional logic - Fixed a typo ("sitcky" → "sticky")
- Moved sticky size adjustment from inside the coordinate calculation closures to directly subtract from the target rectangle bounds, ensuring scrolled content is positioned to be visible below/after sticky headers/columns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
emilk
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.
Also update the demo to test/verify scrolling to specific rows/columns.