Skip to content

Fix test execution seeping into lint-only job that didn't have software rasterizer setup #10025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 20, 2025

@Wumpf Wumpf requested a review from jprochazk May 20, 2025 20:07
@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels May 20, 2025
Copy link

github-actions bot commented May 20, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
84268b0 https://rerun.io/viewer/pr/10025 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented May 20, 2025

@rerun-bot full-check

Copy link

@Wumpf
Copy link
Member Author

Wumpf commented May 20, 2025

@rerun-bot full-check

Copy link

if: ${{ inputs.CHANNEL == 'main' }}
run: pixi run rs-check --skip individual_crates docs_slow
run: pixi run rs-check --skip individual_crates docs_slow tests tests_without_all_features # Tests run in a separate job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that makes more sense. Thanks for looking into this

@jprochazk jprochazk merged commit a008fe3 into main May 20, 2025
108 of 125 checks passed
@jprochazk jprochazk deleted the andreas/try-fix-ci branch May 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants