Use egui atoms in help view #10224
Merged
Use egui atoms in help view #10224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
added
ui
|
Superseeded by |
Yeah, but I did some atomics related changes here, so this should still be merged |
# Conflicts: # Cargo.lock # crates/viewer/re_viewer/tests/snapshots/all_view_selecion_uis/Dark/TimeSeries.png # crates/viewer/re_viewer/tests/snapshots/all_view_selecion_uis/Light/TimeSeries.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
AtomLayout, abstracing layouting within widgets emilk/egui#5830)What
Updates egui to latest master and uses atoms in the help view, removing the icon_text macro since it was basically atomics lite
Seems like the snapshots the only thing that changed is the three dot icon slightly moved. But it seems a bit clearer now, so that's a win.