-
Notifications
You must be signed in to change notification settings - Fork 595
Remove items marked as deprecated before 0.27 #12204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes deprecated functionality from the Rerun SDK that was previously marked for deletion. The changes clean up old APIs across Python and Rust codebases, including deprecated functions for time setting, image encoding, video timestamps, and web serving.
Key Changes
- Removed deprecated time-setting functions (
set_time_sequence,set_time_seconds,set_time_nanos) in favor of the unifiedset_timeAPI - Deleted deprecated
serve_webfunctions, consolidating toserve_grpc+serve_web_viewerpattern - Removed deprecated helper classes and functions for image encoding, video timestamps, and geometric types
- Eliminated outdated function names and their corresponding test files
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rerun_py/tests/unit/test_image_encoded.py | Removed entire test file for deprecated ImageEncoded functionality |
| rerun_py/src/dataframe/recording_view.rs | Deleted deprecated filter_range_seconds method |
| rerun_py/rerun_sdk/rerun/time.py | Removed deprecated time-setting functions and their import |
| rerun_py/rerun_sdk/rerun/sinks.py | Deleted deprecated serve_web function |
| rerun_py/rerun_sdk/rerun/recording_stream.py | Removed deprecated new_recording, serve_web, and time-setting methods |
| rerun_py/rerun_sdk/rerun/notebook.py | Cleaned up deprecated parameter handling in set_time_ctrl |
| rerun_py/rerun_sdk/rerun/archetypes/video_frame_reference_ext.py | Removed deprecated columns_seconds, columns_milliseconds, and columns_nanoseconds methods |
| rerun_py/rerun_sdk/rerun/archetypes/asset_video_ext.py | Deleted deprecated read_frame_timestamps_ns method |
| rerun_py/rerun_sdk/rerun/any_value.py | Removed deprecated with_field and with_component methods |
| rerun_py/rerun_sdk/rerun/_send_columns.py | Deleted deprecated time column classes (TimeSequenceColumn, TimeSecondsColumn, TimeNanosColumn) |
| rerun_py/rerun_sdk/rerun/_image_encoded.py | Removed entire deprecated image encoding helper file |
| rerun_py/rerun_sdk/rerun/init.py | Cleaned up exports of deprecated functionality |
| crates/top/re_sdk/src/recording_stream.rs | Removed deprecated serve_web, set_time_secs, and set_time_nanos methods |
| crates/top/re_sdk/src/lib.rs | Deleted deprecated default_server_addr function |
| crates/store/re_sdk_types/src/datatypes/angle_ext.rs | Removed deprecated Degrees and Radians methods |
| crates/store/re_sdk_types/src/components/video_timestamp_ext.rs | Deleted deprecated from_seconds, from_milliseconds, and from_nanoseconds methods |
| crates/store/re_sdk_types/src/components/scale3d_ext.rs | Removed deprecated Uniform and ThreeD methods |
| crates/store/re_sdk_types/src/archetypes/pinhole_ext.rs | Deleted multiple deprecated projection and resolution methods |
| crates/store/re_sdk_types/src/archetypes/image_ext.rs | Removed deprecated file-loading methods |
| crates/store/re_sdk_types/src/archetypes/asset_video_ext.rs | Deleted deprecated read_frame_timestamps_ns method |
| crates/store/re_sdk_types/src/archetypes/asset3d_ext.rs | Removed deprecated from_file method |
| crates/store/re_log_types/src/index/timeline.rs | Deleted deprecated new_temporal method |
| crates/store/re_chunk/src/chunk.rs | Removed deprecated new_seconds and new_nanos methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
I was getting ready to mark load_recording as deprecated and was looking over how we generally manage this. Saw we mark things deprecated in a few different ways and often forget to actually delete them. Try to make a quick pass to actually remove old cruft.