Skip to content

Add __eq__ to Entry #12209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abey79 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add __eq__ to Entry #12209

abey79 wants to merge 2 commits into from
+28 −1

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Dec 15, 2025

Related

What

Title. This enables the following patterns:

# Does a given entry name exist?
"entry_name" in client.entries()

# Does a given entry id exist?
entry_id in client.entries()

@abey79 abey79 added sdk-python Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 15, 2025
@abey79 abey79 requested a review from ntjohnson1 December 15, 2025 09:44
ntjohnson1
ntjohnson1 approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@ntjohnson1 ntjohnson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to have a test on this.

rerun_py/rerun_sdk/rerun/catalog/_entry.py
return NotImplemented

# Make it explicit that `Entries` are view objects for which hashing cannot sensibly be implemented
__hash__ = None
Copy link
Member

@ntjohnson1 ntjohnson1 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross
python/mypy#4266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntjohnson1 ntjohnson1 ntjohnson1 approved these changes

Assignees

No one assigned

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md sdk-python Python logging API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abey79 @ntjohnson1