Skip to content

Fix notification popup instantly closing #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmerlin merged 1 commit into from
May 8, 2025
Merged

Fix notification popup instantly closing #9923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/viewer/re_ui/src/notifications.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,13 @@ impl NotificationUi {
}

fn ui(&mut self, egui_ctx: &egui::Context, button_response: &egui::Response) {
let is_panel_visible =
egui_ctx.memory(|mem| mem.is_popup_open(notification_panel_popup_id()));
let is_panel_visible = egui_ctx.memory_mut(|mem| {
let is_open = mem.is_popup_open(notification_panel_popup_id());
if is_open {
mem.keep_popup_open(notification_panel_popup_id());
}
is_open
});
if is_panel_visible {
// Dismiss all toasts when opening panel
self.unread_notification_level = None;
Expand Down
8 changes: 7 additions & 1 deletion crates/viewer/re_ui/src/ui_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,13 @@ pub trait UiExt {
) -> Option<R> {
let ui = self.ui();

if !ui.memory(|mem| mem.is_popup_open(popup_id)) {
if !ui.memory_mut(|mem| {
let is_open = mem.is_popup_open(popup_id);
if is_open {
mem.keep_popup_open(popup_id);
}
is_open
}) {
return None;
}

Expand Down
Loading