-
Notifications
You must be signed in to change notification settings - Fork 447
ChunkComponents::contains_component
and removal of ComponentNameSet
#9927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually, `re_view_dataframe` still uses `ComponentNameSet`
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all good to me! Another step towards a clean fully tagged future 🚢
merged in |
All of these changes are part of #9938 now too. |
Related
What
This changes
ChunkComponents::contains_component_name
tocontains_component
that takes a descriptor. Also removesComponentNameSet
in favor ofComponentDescriptorSet
.Note
re_view_dataframe
still usesComponentNameSet
until we sort out descriptors in dataframes.Important
I've double checked the
compatible_component_set
inimpl ViewContextSystem for EntityDepthOffsets
, but maybe have a closer look there. 🙏