Skip to content

ChunkComponents::contains_component and removal of ComponentNameSet #9927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented May 8, 2025

Related

What

This changes ChunkComponents::contains_component_name to contains_component that takes a descriptor. Also removes ComponentNameSet in favor of ComponentDescriptorSet.

Note re_view_dataframe still uses ComponentNameSet until we sort out descriptors in dataframes.

Important

I've double checked the compatible_component_set in impl ViewContextSystem for EntityDepthOffsets, but maybe have a closer look there. 🙏

Actually, `re_view_dataframe` still uses `ComponentNameSet`
@grtlr grtlr requested a review from Wumpf May 8, 2025 14:42
@grtlr grtlr added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 8, 2025
Copy link

github-actions bot commented May 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
fd719d7 https://rerun.io/viewer/pr/9927 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good to me! Another step towards a clean fully tagged future 🚢

@Wumpf
Copy link
Member

Wumpf commented May 8, 2025

merged in main to resolve conflicts I caused, still needs some attention on failing test

@grtlr
Copy link
Contributor Author

grtlr commented May 9, 2025

All of these changes are part of #9938 now too.

@grtlr grtlr closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants