This repository was archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyppy
reviewed
May 14, 2020
ryyppy
reviewed
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as you get the newest changes from master, we will have an easier time previewing the end result in our PR deployment.
As always, take my stylistic comments as recommendations :-)
Co-authored-by: Patrick Stapfer <[email protected]>
rebased |
ryyppy
approved these changes
May 14, 2020
feel free to merge this when ready. Date is set to May 15, which is Friday, so I guess this is the release date? I also just realized that there was another feedback loop going on in the bucklescript.github.io repo...we'll just double check what will be the most current version then! |
@ryyppy that feedback is already addresed |
I don't have permissison to merge it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference https://github.com/BuckleScript/bucklescript.github.io/pull/211