Introduction of the AudioDestinationNode module #83
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudioDestinationNode is a subclass of AudioNode with no constructor and no extra method. The only effective difference is the `maxChannelCount` instance property, which is already covered by the `audioDestinationNode` type in the `WebAudioAPI` module. This PR allows for `AudioContext`'s `destination` property to be used like an `AudioNode`, especially being connected to by other nodes since this is the only way to output audio to speakers. For more information, check [MDN](https://developer.mozilla.org/en-US/docs/Web/API/AudioDestinationNode)
julien-deoux
force-pushed
the
AudioDestinationNode
branch
from
dfc5b1f to
966e80f
Compare
nojaf
approved these changes
Apr 19, 2025
There was a problem hiding this comment.
Thanks for adding the unit test!
https://www.npmjs.com/package/@rescript/webapi/v/0.1.0-experimental-45ad9b8 should contain you fixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AudioDestinationNodeis a subclass of AudioNode with no constructor and no extra method. The only effective difference is themaxChannelCountinstance property, which is already covered by theaudioDestinationNodetype in theWebAudioAPImodule.This PR allows for
AudioContext'sdestinationproperty to be used like anAudioNode, especially being connected to by other nodes since this is the only way to output audio to speakers.For more information, check MDN