Don't filter out module-related type errors #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
commented
May 9, 2025
Comment on lines
+686
to
+691
| d.message.startsWith("Multiple definition of the") || | ||
| // The signature mismatch, with mismatch and ill typed applicative functor | ||
| // type errors all include the filepath with LOC | ||
| d.message.startsWith("Signature mismatch") || | ||
| d.message.startsWith("In this `with' constraint") || | ||
| d.message.startsWith("This `with' constraint on") |
There was a problem hiding this comment.
Instead of manually baking in these conditions, we could instead check for stderr.trimStart().startsWith("We've found a bug for you") 🤔
zth
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Not_included,With_mismatchandWith_makes_applicative_functor_ill_typederrors fromtypemod.mluseIncludemod.report_errorto report errors, which includes filepaths in its output.Like in #1086, by checking for the presence of these errors we're ensuring that the user will not incorrectly see a 'something has gone wrong with incremental typechecking' warning notification.