group Jsx modules
#7347
Draft
group Jsx modules
#7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a top-level module for `Jsx`. It contains the following submodules: - `Jsx.DOMStyle` - `Jsx.Event` - `Jsx.DOM` Deprecate `JsxDOM.res`, `JsxDOMStyle` and `JsxEvent` `JsxDOM.res` code has been duplicated to avoid cyclic dependency. With these changes we can have a section in the sidebar menu for the `Jsx` module containing `DOM`, `DOMStyle` and `Event`
cknitt
reviewed
Mar 18, 2025
| @@ -21,6 +21,7 @@ | |||
| } | |||
| }, | |||
| "../../..": { | |||
| "name": "rescript", | |||
There was a problem hiding this comment.
Not sure why this keeps changing back and forth.
Probably depending on the npm version used?
If we want this change, we should do it in a separate PR for all package-lock.json files.
| @@ -60,4 +60,4 @@ module Elements = { | |||
| external jsxsKeyed: (string, props, ~key: string=?, @ignore unit) => Jsx.element = "jsxs" | |||
|
|
|||
| external someElement: element => option<element> = "%identity" | |||
| } | |||
| module Event = JsxEvent | ||
| module DOM = { | ||
| type style = DOMStyle.t | ||
| type domRef |
There was a problem hiding this comment.
I think it is problematic that the types defined here (other than style) are different from those in JsxDOM. They should all be aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a top-level module for
Jsx. It contains the following submodules:Jsx.DOMStyleJsx.EventJsx.DOMDeprecate
JsxDOM.res,JsxDOMStyleandJsxEventJsxDOM.rescode has been duplicated to avoid cyclic dependency.With these changes we can have a section in the sidebar menu for the
Jsxmodule containingDOM,DOMStyleandEvent