-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Yarn workspace #7357
Use Yarn workspace #7357
Conversation
52f097c
to
a098fe1
Compare
The "workspace:" protocol helped to create |
Personally I like this a lot (big fan of yarn and using it in all our company projects). Not sure how people not usually using yarn feel about it though. I see you tried the same with npm in #7356, but it was not feasible? The contributing guide would also need to be updated for yarn. |
I tried npm first, but the difference in how workspace dependencies are linked had an unintended impact on the docstring tests. npm doesn't provide any functionality for workspaces other than basic installation, so there is no workaround. yarn provides more options here, such as |
529e468
to
f2f52c3
Compare
Could you also add a CHANGELOG entry? |
f6c1098
to
f0239ac
Compare
Done. Honestly, I'm not sure we should keep verbose logs for not user-facing changes. We do have context in PRs anyway |
Thanks!
Certainly not for the small stuff, but I thought this one was a big enough internal change to warrant putting it into the CHANGELOG. |
Solves #7298
Experiment using Yarn workspace instead of #7356
Yarn's advantage:
yarn up @rescript/react "@biomejs/*"