Skip to content

Normalize ordinary string literals at the frontend - #8603

Closed
cknitt wants to merge 10 commits into
rescript-lang:masterfrom
cknitt:codex/fix-equivalent-string-patterns
Closed

Normalize ordinary string literals at the frontend#8603
cknitt wants to merge 10 commits into
rescript-lang:masterfrom
cknitt:codex/fix-equivalent-string-patterns

Reject malformed UTF-8 in string literals

f400ea7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 1, 2026 in 1s

76.54% (+0.09%) compared to 59372ec

View this Pull Request on Codecov

76.54% (+0.09%) compared to 59372ec

Details

Codecov Report

❌ Patch coverage is 85.98131% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.54%. Comparing base (59372ec) to head (f400ea7).

Files with missing lines Patch % Lines
compiler/syntax/src/res_scanner.ml 43.75% 9 Missing ⚠️
compiler/ml/ast_mapper_from0.ml 75.00% 8 Missing ⚠️
compiler/ml/string_literal.ml 91.35% 7 Missing ⚠️
compiler/gentype/import_path.ml 75.00% 6 Missing ⚠️
tests/ounit_tests/ounit_ast_mapper0_tests.ml 90.90% 5 Missing ⚠️
tests/ounit_tests/ounit_string_literal_tests.ml 91.93% 5 Missing ⚠️
compiler/gentype/translate_type_declarations.ml 60.00% 2 Missing ⚠️
compiler/syntax/src/res_printer.ml 50.00% 2 Missing ⚠️
compiler/syntax/src/res_outcome_printer.ml 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8603      +/-   ##
==========================================
+ Coverage   76.44%   76.54%   +0.09%     
==========================================
  Files         478      481       +3     
  Lines       63163    63462     +299     
==========================================
+ Hits        48286    48578     +292     
- Misses      14877    14884       +7     
Files with missing lines Coverage Δ
compiler/core/j.ml 100.00% <ø> (ø)
compiler/core/js_dump.ml 88.08% <ø> (-0.02%) ⬇️
compiler/core/js_exp_make.ml 64.20% <100.00%> (-0.28%) ⬇️
compiler/frontend/ast_utf8_string_interp.ml 69.64% <100.00%> (+2.05%) ⬆️
compiler/gentype/emit_text.ml 95.00% <100.00%> (+9.28%) ⬆️
compiler/gentype/translate_core_type.ml 76.92% <100.00%> (+1.92%) ⬆️
compiler/ml/ast_mapper_to0.ml 62.93% <100.00%> (+0.55%) ⬆️
compiler/ml/external_arg_spec.ml 100.00% <ø> (ø)
tests/ounit_tests/ounit_gentype_tests.ml 100.00% <100.00%> (ø)
tests/ounit_tests/ounit_lambda_constant_tests.ml 100.00% <ø> (ø)
... and 10 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.