Skip to content

Add regression tests for doc comment attribute formatting - #8613

Merged
cknitt merged 1 commit into
masterfrom
codex/test-doc-comment-attributes
Sep 4, 2026
Merged

Add regression tests for doc comment attribute formatting#8613
cknitt merged 1 commit into
masterfrom
codex/test-doc-comment-attributes

Conversation

@cknitt

@cknitt cknitt commented Sep 4, 2026

Copy link
Copy Markdown
Member

Adds the four examples from #6302 as formatter regression tests, verifying that single-line and multiline doc comments preserve the same attribute layout as normal comments. The underlying behavior was fixed in #7529.

Validation: make test-syntax, make test-syntax-roundtrip, and narrow-width formatting stability checks passed.

Closes #6302.

Signed-off-by: Christoph Knittel <ck@cca.io>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T10:00:48.853062Z 0b88b64 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.32%. Comparing base (5c24235) to head (0b88b64).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8613      +/-   ##
==========================================
- Coverage   77.32%   77.32%   -0.01%     
==========================================
  Files         467      467              
  Lines       63342    63313      -29     
==========================================
- Hits        48982    48957      -25     
+ Misses      14360    14356       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8613

@rescript/belt

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/belt@8613

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8613

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8613

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8613

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8613

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8613

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8613

commit: 0b88b64

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

@cknitt
cknitt merged commit d4699e9 into master Sep 4, 2026
29 checks passed
@cknitt
cknitt deleted the codex/test-doc-comment-attributes branch September 4, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc comment affects formatting of attributes

2 participants