fix: InboundAttachment filename should be an Option<String>#39
Merged
AntoniosBarotsis merged 2 commits intoresend:mainfrom Feb 3, 2026
Merged
fix: InboundAttachment filename should be an Option<String>#39AntoniosBarotsis merged 2 commits intoresend:mainfrom
AntoniosBarotsis merged 2 commits intoresend:mainfrom
Conversation
this field is sometimes null when returned by the API, so it should be an Option
Collaborator
|
Hello! Thanks for the report, apologies for taking a few days to respond. I'll talk to the resend team before merging as this might be a bug in their backend. |
Collaborator
|
@thomasmost again sorry for the delay. This was an issue in the Node SDK (i.e. you were right that it could be null). Will be releasing a new version in a few minutes. Thanks for bringing it up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this field is sometimes null when returned by the API, so it should be an Option
Summary by cubic
Make InboundAttachment fields nullable to match API responses and prevent deserialization errors. filename, content_disposition, and size are now Option types.
Written for commit 24df728. Summary will update on new commits.