Skip to content

Comments

fix: InboundAttachment filename should be an Option<String>#39

Merged
AntoniosBarotsis merged 2 commits intoresend:mainfrom
thomasmost:patch-1
Feb 3, 2026
Merged

fix: InboundAttachment filename should be an Option<String>#39
AntoniosBarotsis merged 2 commits intoresend:mainfrom
thomasmost:patch-1

Conversation

@thomasmost
Copy link
Contributor

@thomasmost thomasmost commented Jan 29, 2026

this field is sometimes null when returned by the API, so it should be an Option


Summary by cubic

Make InboundAttachment fields nullable to match API responses and prevent deserialization errors. filename, content_disposition, and size are now Option types.

  • Migration
    • Handle None for filename, content_disposition, and size (e.g., if let Some(..) or unwrap_or).
    • Update pattern matches and trait impls that assumed non-optional values.

Written for commit 24df728. Summary will update on new commits.

this field is sometimes null when returned by the API, so it should be an Option
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@AntoniosBarotsis
Copy link
Collaborator

Hello! Thanks for the report, apologies for taking a few days to respond. I'll talk to the resend team before merging as this might be a bug in their backend.

@AntoniosBarotsis
Copy link
Collaborator

@thomasmost again sorry for the delay. This was an issue in the Node SDK (i.e. you were right that it could be null). Will be releasing a new version in a few minutes. Thanks for bringing it up!

@AntoniosBarotsis AntoniosBarotsis merged commit 1c111fe into resend:main Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants