fix: update permission check for Journal Entry access in GSTR1 class#4367
Draft
Anish59312 wants to merge 1 commit into
Draft
fix: update permission check for Journal Entry access in GSTR1 class#4367Anish59312 wants to merge 1 commit into
Anish59312 wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -47 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GSTR1 class gates show_rcm_journal_entry and show_rounding_diff_journal_entry behind frappe.perm.has_perm("Journal Entry"). This call requires the Journal Entry doctype meta to be loaded client-side — which is not the case here — causing it to consistently resolve to read: 0 and skipping the journal entry display regardless of the user's actual permissions.
frappe/frappe#34658 is not the correct approach to fix this — see frappe/frappe#34658 (comment).
Instead, use frappe.boot.user.can_read.includes("Journal Entry") directly at the call site. Boot data is always available, needs no meta, and is the correct lightweight check for this pattern.
Companion to frappe/frappe#39644