Unable to edit information ... #1279: fixed focus issue - it electro… #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue - it electron bug of focus
|
|
violetadev
reviewed
Aug 10, 2024
| @@ -177,6 +177,30 @@ const createWindow = async () => { | |||
| )}` | |||
| ); | |||
|
|
|||
| const isWindows = process.platform === 'win32'; | |||
There was a problem hiding this comment.
LGTM but @manojVivek can you take a look too? I am not able to test it on windows, I tried it on mac and it doesn't break anything
I have tried it on win32 and works great!
|
@all-contributors Please add @pranavithape for code. |
|
I've put up a pull request to add @pranavithape! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There issue opened at : Unable to edit information of custom device after duplicate name error #1279
Error Is Located In Electron Specifically Its Focus Function , It Electron Feature But It Making User Experience Bad Is Input field's Error So We Fixed By Adding Little Code In Main