edit duplicate variable name #1354
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
violetadev
reviewed
Jan 25, 2025
| setDevices, | ||
| setSuiteDevices, | ||
| } from 'renderer/store/features/device-manager'; | ||
| import { APP_VIEWS, setAppView } from 'renderer/store/features/ui'; |
There was a problem hiding this comment.
thanks for the PR, please follow the following structure:
- Make a file named DeviceManager.tsx for this file
- In the index.tsx file just do
export { DeviceManager } from './DeviceManager-> this acts as a export hub for anything you need to export - Create separate file components for the lines of code I am commenting below
violetadev
reviewed
Jan 25, 2025
Comment on lines
153
to
164
| <div className="flex items-center gap-2"> | ||
| {filteredType === type && <Icon icon="mdi:check" />} | ||
| <span | ||
| className={cx('capitalize', { | ||
| 'font-semibold text-black dark:text-white': | ||
| filteredType === type, | ||
| })} | ||
| > | ||
| {type} | ||
| </span> | ||
| </div> | ||
| ), |
There was a problem hiding this comment.
This is the same as the lines 137 to 147, please refactor into a reusable separate component. You could call it DeviceManagerLabel if you'd like, and pass props to it to handle variations
- Moved the DeviceManager logic to a separate DeviceManager.tsx file - Updated imports - Refactored code as per the PR review into separate DeviceManagerLabel.tsx file - Ensured AppContent now correctly references the DeviceManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #1327
ℹ️ About the PR
This PR adds a filter dropdown to streamline device selection by type (e.g., Phone, Tablet). Users can now filter devices by type or select "All Device Types" to view everything.
I am not sure if the Search Bar is suppose to remain or not. So currently the search bar is still included and works along side the filter dropdown.
🖼️ Testing Scenarios / Screenshots