Fix: Resolve race condition in address bar navigation #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-a167-1a541f512024 Fix race condition in AddressInput component with navigation flags and debouncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a critical race condition in the address bar navigation, which previously caused application crashes during rapid URL entry and navigation. The following improvements have been implemented:
Added navigation flags to prevent duplicate address changes
Introduced debouncing to handle rapid successive navigation calls
Ensured AddressBar and WebView state synchronization
Implemented timeout cleanup to prevent memory leaks
Enhanced update logic to avoid circular update patterns
Testing:
Verified that rapidly typing URLs in the address bar does not cause crashes
Confirmed consistent state synchronization between the address bar and WebView
Checked that navigation retains its intended behavior without performance regressions
This update ensures smoother and more reliable navigation across all supported platforms, with no breaking changes.