fix(ci): resolve zizmor alerts #35 (bot-conditions) and #36 (artipacked)#81
Conversation
- auto-merge.yml: replace github.actor_id check with the immutable pull_request payload (github.event.pull_request.user.login). The actor context can be subverted on workflow re-runs, while user.login on the pull_request event is fixed at trigger time. - release-plz.yml: drop the explicit checkout `token` input and set persist-credentials: false. release-plz-action consumes GITHUB_TOKEN from the step's env block for git push and API calls, so persisting the credential in .git/config only widens the leak surface.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
auto-merge.yml:29: replacedgithub.actor_id == '49699333'withgithub.event.pull_request.user.login == 'dependabot[bot]'. Thepull_requestevent payload is fixed at trigger time and cannot be spoofed via workflow re-runs the waygithub.actor/github.actor_idcan.release-plz.yml:23: removed the explicittoken:input onactions/checkoutand setpersist-credentials: false.release-plz-actionalready readsGITHUB_TOKENfrom the step'senv:block for git push and API calls, so persisting the credential in.git/configonly widens the leak surface.Closes the two open security alerts:
Test plan
zizmoraudits at https://github.com/resq-software/crates/security/code-scanning should drop alerts refactor: extract shared TUI terminal module and slim workspace deps #35 and refactor: apply PR review feedback — glob members, fix deploy-cli broken links, sync CLAUDE.md #36 once master has these workflow changes.if:evaluates true under the new condition (verified locally — dependabot[bot] is the immutable PR author for dependabot/* branches).release-plzstill runs on its weekly cron / manual dispatch — it consumesGITHUB_TOKENfrom the step env, not from.git/config, so removingpersist-credentialsis safe.