Do not output colorized config when environment does not support it #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-amartin
approved these changes
Apr 17, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 12, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [danielgtaylor/restish](https://github.com/danielgtaylor/restish) | minor | `v0.20.0` -> `v0.21.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>danielgtaylor/restish (danielgtaylor/restish)</summary> ### [`v0.21.0`](https://github.com/rest-sh/restish/releases/tag/v0.21.0) [Compare Source](rest-sh/restish@v0.20.0...v0.21.0) In addition to the many changes (see the notes, below), this is the first release at the new package location. Go forth, and update your `go.mod`s! #### What's Changed - docs: improve link accuracy by [@​eitamal](https://github.com/eitamal) in rest-sh/restish#258 - chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in rest-sh/restish#251 - chore(deps): bump google.golang.org/protobuf from 1.28.1 to 1.33.0 by [@​dependabot](https://github.com/dependabot) in rest-sh/restish#242 - Make it possible to use a client certificate stored in hardware by [@​jeffallen](https://github.com/jeffallen) in rest-sh/restish#246 - Expand documentation on external-tool auth by [@​fflores97](https://github.com/fflores97) in rest-sh/restish#256 - Escape '&' for Windows command line oAuth flow by [@​MatthiasScholzTW](https://github.com/MatthiasScholzTW) in rest-sh/restish#253 - Do not output colorized config when environment does not support it by [@​cfunkhouser](https://github.com/cfunkhouser) in rest-sh/restish#270 - chore(deps): bump golang.org/x/image from 0.10.0 to 0.18.0 by [@​dependabot](https://github.com/dependabot) in rest-sh/restish#260 - docs: include command for fish completion help by [@​kbakk](https://github.com/kbakk) in rest-sh/restish#271 - feat: upgrade to Go 1.24 by [@​danielgtaylor](https://github.com/danielgtaylor) in rest-sh/restish#277 - chore(deps): bump golang.org/x/net from 0.23.0 to 0.38.0 by [@​dependabot](https://github.com/dependabot) in rest-sh/restish#276 - fix: send scopes on refresh token requests by [@​danielgtaylor](https://github.com/danielgtaylor) in rest-sh/restish#278 - feat: rename danielgtaylor/restish -> rest-sh/restish by [@​danielgtaylor](https://github.com/danielgtaylor) in rest-sh/restish#281 - docs: fix build status by [@​danielgtaylor](https://github.com/danielgtaylor) in rest-sh/restish#282 - Upgrade libopenapi by [@​terev](https://github.com/terev) in rest-sh/restish#283 #### New Contributors - [@​eitamal](https://github.com/eitamal) made their first contribution in rest-sh/restish#258 - [@​jeffallen](https://github.com/jeffallen) made their first contribution in rest-sh/restish#246 - [@​fflores97](https://github.com/fflores97) made their first contribution in rest-sh/restish#256 - [@​MatthiasScholzTW](https://github.com/MatthiasScholzTW) made their first contribution in rest-sh/restish#253 - [@​cfunkhouser](https://github.com/cfunkhouser) made their first contribution in rest-sh/restish#270 - [@​kbakk](https://github.com/kbakk) made their first contribution in rest-sh/restish#271 - [@​terev](https://github.com/terev) made their first contribution in rest-sh/restish#283 **Full Changelog**: rest-sh/restish@v0.20.0...v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41MC4wIiwidXBkYXRlZEluVmVyIjoiNDAuNTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, regardless of the
COLOR/NOCOLORenvironment settings, the output ofrestish api show $APIis output in color. This is quite inconvenient when piping the output to other programs which are unable to process the ANSI color codes. In my case, this specifically breaks piping the output intojq.For example, with the current release:
With this fix included: