Skip to content

Conversation

muhamadazmy
Copy link
Contributor

@muhamadazmy muhamadazmy commented Jun 23, 2025

[invoker] Attach deployment id to the invoker error

This is used in the next PR to associate the deployment unreachable
failure with the deployment id


Stack created with Sapling. Best reviewed with ReviewStack.

This is used in the next PR to associate the deployment unreachable
failure with the deployment id
Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AhmedSoliman
Copy link
Contributor

I guess the need to merge this is subject to whether #3426 is actually needed or not

@slinkydeveloper
Copy link
Contributor

Just a question here, why decorating every error? isn't the info of the deployment id already in InvocationStatusStore?

@muhamadazmy muhamadazmy marked this pull request as draft August 27, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants