Don't send unexpired invocations across threads #3742
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleaner suffers from a lot of contention due to sending all invocations, including unexpired ones, from the io thread to the worker thread. It's better if we can check for expiry inside the io thread, but we don't want to put all that logic inside the partition store crate. So we use a filter_map method to identify the invocations we care about and send them back to the worker.
Before:
After: