Clean up the SubscriptionValidator abstraction. #3866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abstraction these days, it was introduced long ago when we didn't have Configuration::pinned.
muhamadazmy
approved these changes
Oct 7, 2025
Comment on lines
+1265
to
+1266
| if !(cluster_options.contains_key("client.id") | ||
| || subscription.metadata().contains_key("client.id")) |
There was a problem hiding this comment.
I know this code just moved around. but would appreciate if you explain to me this condition here.
There was a problem hiding this comment.
client.id is the consumer group id in kafka.
We set this at registration time, when the user didn't provide it, to avoid that it gets auto regenerated, thus avoiding that a new new consumer group gets created on each "restart" of the kafka subscription
slinkydeveloper
deleted the
issues/improve-schema-registry-organization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a useful abstraction these days, it was introduced long ago when we didn't have
Configuration::pinned.Followup of #3859