Harden three_logserver_readstream_with_trims #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can remove the PartitionProcessorRpcError::Busy because we use flexbuffers to encode the error variants when sending them over the wire and flexbuffers encodes the variants by name.
When trimming the log in the replicated setup, we cannot guarantee that all log servers have seen the trim gap. Therefore, we need to make the assertions a little bit more forgiving. Note, this commit only fixes the test instability and leaves the trim semantics untouched. This fixes restatedev#3890.
AhmedSoliman
approved these changes
Oct 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trimming the log in the replicated setup, we cannot guarantee that all
log servers have seen the trim gap. Therefore, we need to make the assertions
a little bit more forgiving.
Note, this commit only fixes the test instability and leaves the trim semantics
untouched.
This fixes #3890.