Added a way to dynamically set the logger facade #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to using JULI logger facade in regular Java SE environments, this enhancements dynamically set a special facade if the Restlet Engine is created by a ServerServlet, allowing the default behavior to be overridden.
Collaborator
Author
|
@thboileau Could you review this contribution? Does the logic look good? I haven't done any testing yet. |
Fixed merge issue
Fixed merge issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim
By default Restlet application logging doesn't go thru the Servlet logging mechanism, but through the JVM mechanism.
The solution
In addition to using JULI logger facade in regular Java SE environments, this enhancements dynamically set a special facade if the Restlet Engine is created by a ServerServlet, allowing the default behavior to be overridden.
DO NOT REVIEW