Skip to content

Add deps.edn and fix compose fn #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

CHNB128
Copy link

@CHNB128 CHNB128 commented May 30, 2020

No description provided.

@CHNB128 CHNB128 changed the title Add deps.edn Add deps.edn and fix compose fn May 30, 2020
@retro
Copy link
Owner

retro commented Jun 1, 2020

Hey, thank you for this PR. I see that you've added deps.edn . Since this project is using leiningen can you remove deps.edn for now, and ensure that the deps are managed through project.clj .

If there is a reason to switch to deps.edn, I would be ok with it, but I don't have too much experience (yet) with the publishing process using deps.edn, so please add another PR for that.

@CHNB128
Copy link
Author

CHNB128 commented Jun 7, 2020

Hi,deps.ednneed to use library in clojurescript projects, wich can't be or not yet supported lein.
So for better compability I suggest to support it as well.
And about splitting deps file into different pr, yeah, it make sense.

@CHNB128
Copy link
Author

CHNB128 commented Jun 7, 2020

And sorry for the trash in commits. I don't wont to merge them all in context of this pr. I just not well familiar with GitHub flow of merge over fork.
I just added some of them for my purpoces, without any desire to add include they there.

@CHNB128
Copy link
Author

CHNB128 commented Jun 7, 2020

To be honest, I have big load on work, so I haven't time to clean this pr.
Sorry for that.
If you need some of they, I think you can cherry pick they.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants