Skip to content

Fix Door duplication bug#184

Merged
zavdav merged 2 commits intomasterfrom
Garsooon-Door-dupe
Mar 26, 2026
Merged

Fix Door duplication bug#184
zavdav merged 2 commits intomasterfrom
Garsooon-Door-dupe

Conversation

@Garsooon
Copy link
Copy Markdown
Member

@Garsooon Garsooon commented Mar 26, 2026

📌 Pull Request

Description

Fixes a door duplication bug where an open trap door would cause a physics event when a door was placed neighboring it to remove the bottom half of the door leaving the top of the door remaining producing 2 door drops (iron and wood )

Type of Change

Please tick all that apply:

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ⚡ Performance improvement
  • 🧩 New feature (non-breaking)
  • 🔧 Refactor / cleanup (no functional changes)
  • 🔥 Crash / exploit fix
  • 📚 Documentation update
  • ❗ Breaking change (may affect plugins or server behavior)

Testing Performed

Describe how this change was tested.
Include environments, steps, and results.

  • Compiled successfully with mvn clean package
  • Tested on a Beta 1.7.3 server
  • Existing functionality verified
  • Edge cases considered

Test details:

Compiled and ran on local text server, tried to reproduce bug and wasn't able to. Redstone had no affect when placing the doors

Logs / Screenshots (if applicable)

Original report https://discord.com/channels/654195300478746625/688899476978401357/1486152906158903416

Compatibility Considerations

  • No known compatibility impact
  • Potential plugin impact (described below)
  • Network / protocol (Netcode) behavior changed
  • Configuration change required

Checklist

Please confirm the following:

  • No unnecessary formatting or whitespace-only changes
  • Changes are compatible with Minecraft Beta 1.7.3
  • No dependencies have been added without discussion with the RetroMC team

@Garsooon Garsooon requested review from a team and RhysB March 26, 2026 14:42
@Garsooon Garsooon added the bug Something isn't working label Mar 26, 2026
Copy link
Copy Markdown
Contributor

@zavdav zavdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the // Poseidon markers to the changes

otherwise looks good, will test myself to confirm

@Garsooon Garsooon requested a review from zavdav March 26, 2026 14:45
@Garsooon
Copy link
Copy Markdown
Member Author

changes added

Copy link
Copy Markdown
Contributor

@zavdav zavdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, works

@zavdav zavdav merged commit 219cc47 into master Mar 26, 2026
3 checks passed
@Garsooon Garsooon deleted the Garsooon-Door-dupe branch March 26, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants