Ensure file loading order respects dependencies.#187
Closed
RobertWesner wants to merge 2 commits intomasterfrom
Closed
Ensure file loading order respects dependencies.#187RobertWesner wants to merge 2 commits intomasterfrom
RobertWesner wants to merge 2 commits intomasterfrom
Conversation
Author
|
Forgot the file extension/filter matching, will add that. |
Author
|
Closing in favor of #188 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request
Description
This PR implements a proper plugin loading order to respect dependencies.
Motivation & Context
A proper standalone Kotlin plugin is impossible without this feature.
Type of Change
Please tick all that apply:
Testing Performed
Debugged right into
SimplePluginManager::loadPlugins():194, checked the order, was happy with the results.mvn clean packageLogs / Screenshots (if applicable)
dummy_jars.zip
Checklist
Please confirm the following:
Thanks for contributing to Project Poseidon!