Skip to content

Webserver#103

Open
oelegeirnaert wants to merge 18 commits into
reuterbal:developmentfrom
oelegeirnaert:webserver
Open

Webserver#103
oelegeirnaert wants to merge 18 commits into
reuterbal:developmentfrom
oelegeirnaert:webserver

Conversation

@oelegeirnaert
Copy link
Copy Markdown

Hi Balthasar,

I'm happy to share this code with you.
Still a lot of improvements needs to be done.
But in this way, your able to test the code already writen.

I think I still need to write a webserver teardown event to properly close the program.
If you have any questions, to not hesitate to contact me.

Kr,
Oele Geirnaert

@reuterbal
Copy link
Copy Markdown
Owner

Hi Oele,
thank you for your contribution! This is really great!
I will look at the additions and probably come back with some questions or suggestions. Please give me a little time for that as I am quite busy at the moment...

@oelegeirnaert
Copy link
Copy Markdown
Author

Yeah, the more suggestions the beter!
Looking forward to create a super photobooth.

@wikijm
Copy link
Copy Markdown
Collaborator

wikijm commented Apr 23, 2019

Hi @oelegeirnaert

Any screen capture to share?

EDIT: My bad, you give it here: https://github.com/oelegeirnaert/photobooth/blob/webserver/screenshots/photobooth_gallery.png

@alopezbu
Copy link
Copy Markdown

alopezbu commented May 25, 2019

Hi @reuterbal
If you are still interested in implementing a webserver, this user has done it in his project:
https://github.com/philipptrenz/photo-booth
but my knowledge is not enough to merge it on your project

@wikijm
Copy link
Copy Markdown
Collaborator

wikijm commented May 25, 2019

Hi @reuterbal,

Do you have some time to review this pull request?
It's seems to have awesome new features 😍

@reuterbal
Copy link
Copy Markdown
Owner

I started to work on that but I want to change a few things to keep this as simple as possible and rather offer an easy interface for custom additions to suit individual needs.

I'll have to ask you for a little more patience :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants