200127 mitch sonarcloud cleanup #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HttpClientErrorException in @RestControllerAdvice, all Optional.get calls are replaced with Optional.orElseThrow calls which produce HttpClientErrorExceptions with corresponding failure types. Fixed Reported SonarCloud issue regarding reassignment of method parameter in DistanceServiceImpl. Refactored List -> Array conversion to use simple stream conversion - whole logic could probably use a revisit. Autoformated code
…urity compliance. Migrated BatchService loading to service layer, added DTO to Entity conversion to service layer, updated unit tests to support new workflow. Removed BatchService dependency from UserController, added BatchService dependency to UserService
…g structure, replaced System.out with logging output in JSONReaderService
…n that files were excluded - should finally work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for issues reported by SonarCloud