fix: migrate to golangci-lint v2#779
Conversation
|
Hey :) We're looking at mitigating this internally. Just before we do, I thought worth asking - is this likely to be merged in minutes/couple hours, or more like several hours/days? Not looking to pressure, all good if it'll take some time! 😄 |
|
@billinghamj uses: reviewdog/action-golangci-lint@v2
with:
golangci_lint_version: 1.64.8 # pin golangci-lint version |
|
Yeah that's our mitigation :) We usually just prefer not to pin as it's easy to forget about it Will go with that for now |
|
For me I needed the "v" otherwise got a not found: - name: golangci-lint
uses: reviewdog/action-golangci-lint@3dfdce20f5ca12d264c214abb993dbb40834da90 # v2.7.2
with:
fail_level: error
golangci_lint_version: v1.64.8 # pin golangci-lint version
golangci_lint_flags: "--config=.github/.golangci.yml ./..." |
pranc1ngpegasus
force-pushed
the
fix/migrate-to-golangci-lint-v2
branch
2 times, most recently
from
d89cbd7 to
e90c183
Compare
pranc1ngpegasus
force-pushed
the
fix/migrate-to-golangci-lint-v2
branch
6 times, most recently
from
1f18463 to
167dd74
Compare
pranc1ngpegasus
force-pushed
the
fix/migrate-to-golangci-lint-v2
branch
from
167dd74 to
5a4f816
Compare
| golint: | ||
| name: runner / golint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - name: golint | ||
| uses: ./ | ||
| with: | ||
| github_token: ${{ secrets.github_token }} | ||
| golangci_lint_flags: "--disable-all -E golint ./testdata" | ||
| tool_name: golint | ||
| level: warning | ||
|
|
There was a problem hiding this comment.
📝 https://golangci-lint.run/product/migration-guide/#deprecated-linters
golint is deprecated.
| exclusions: | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling |
There was a problem hiding this comment.
| check-blank: false | ||
|
|
||
| linters: | ||
| default: none |
There was a problem hiding this comment.
|
🚀 [bumpr] Bumped! New version:v2.8.0 Changes:v2.7.2...v2.8.0 |
4 participants
golangci-lint has released v2. And some command line options has deprecated.
In this PR, migrate command line options to v2. And switch them between v1 and v2.
v1
golangci-lint run --out-format line-numberv2
golangci-lint run --output.text.path stdoutref: https://golangci-lint.run/product/migration-guide/#outputformatsformat-line-number