Add checksum verification for trivy downloads#108
Open
volker-fr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change: Enforce Checksum Verification for Trivy Binaries
Problem:
Currently, the action downloads the Trivy binary without verifying its integrity. Since GitHub releases can be deleted and re-created, this poses a supply chain risk. There have been documented supply chain attacks targeting Trivy in the past.
Proposed Solutions:
Checksum Feature Flag: Allow users to provide a known SHA256 checksum via a GitHub Action input. Mainly for new versions not covered in the hardcoded checksum list.
Hardcoded Checksum list: Maintain a local mapping of versions to SHA256 checksums within the action logic.
Implementation Note:
To ensure 100% coverage using a local manifest, the trivy version must be pinned. Using the latest tag would cause the action to fail if a new version is released that is not yet present in our local checksum list. This keeps compatibility with the existing default workflow setting.