Repository navigation
chore: store revive version in file - #90
Merged
alexandear merged 1 commit intoSep 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are consistent and no blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Moves the published Revive version into a tracked REVIVE_VERSION file used by CI.
Changes:
- Adds
REVIVE_VERSIONcontainingv1.16.0. - Updates workflows to read and commit the version file.
- Documents the new version-tracking process.
| File | Description |
|---|---|
REVIVE_VERSION |
Stores the published Revive release. |
README.md |
Documents version tracking and workflow behavior. |
.github/workflows/check.yaml |
Reads the stored version for checks. |
.github/workflows/build.yaml |
Updates and commits the version file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the revive release the website was built from in a
REVIVE_VERSIONfile instead of a repository variable.The Actions token can't write repository variables.
actions: writecovers runs, artifacts and caches, but not variables, so the last run of the old workflow failed with:Making that work needs a fine-grained PAT with
Variables: read and write, kept in a secret and rotated before it expires. The file needs none of it, since the Build workflow already hascontents: writeto commitdocs/.The file is also committed together with the regenerated
docs/, so the version and the site it produced can't drift apart. With a variable they were two separate steps, and when the second one 403'd the site went to v1.17.0 while the variable was never updated. Now the version shows up ingit logand in PR diffs, and a PR can pointcheck.yamlat another tag and let CI build it.