Skip to content

chore: store revive version in file - #90

Merged
alexandear merged 1 commit into
revive-lint:masterfrom
alexandear-org:fix/store-version-in-file
Sep 23, 2026
Merged

alexandear merged 1 commit into
revive-lint:masterfrom
alexandear-org:fix/store-version-in-file

Conversation

@alexandear

@alexandear alexandear commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Keeps the revive release the website was built from in a REVIVE_VERSION file instead of a repository variable.

The Actions token can't write repository variables. actions: write covers runs, artifacts and caches, but not variables, so the last run of the old workflow failed with:

failed to set variable "REVIVE_VERSION": HTTP 403: Resource not accessible by integration

Making that work needs a fine-grained PAT with Variables: read and write, kept in a secret and rotated before it expires. The file needs none of it, since the Build workflow already has contents: write to commit docs/.

The file is also committed together with the regenerated docs/, so the version and the site it produced can't drift apart. With a variable they were two separate steps, and when the second one 403'd the site went to v1.17.0 while the variable was never updated. Now the version shows up in git log and in PR diffs, and a PR can point check.yaml at another tag and let CI build it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All reviewed changes are consistent and no blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Moves the published Revive version into a tracked REVIVE_VERSION file used by CI.

Changes:

  • Adds REVIVE_VERSION containing v1.16.0.
  • Updates workflows to read and commit the version file.
  • Documents the new version-tracking process.
File Description
REVIVE_VERSION Stores the published Revive release.
README.md Documents version tracking and workflow behavior.
.github/​workflows/​check.yaml Reads the stored version for checks.
.github/​workflows/​build.yaml Updates and commits the version file.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alexandear
alexandear merged commit 454f303 into revive-lint:master Sep 23, 2026
1 check passed
@alexandear
alexandear deleted the fix/store-version-in-file branch September 23, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants