Skip to content

chore: split tools into separate modules - #1960

Merged
alexandear merged 15 commits into
revive-lint:masterfrom
alexandear:tools-add-goreleaser
Nov 12, 2026
Merged

alexandear merged 15 commits into
revive-lint:masterfrom
alexandear:tools-add-goreleaser

Conversation

@alexandear

@alexandear alexandear commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Adds goreleaser as a Go tool dependency, so Renovate can update it, and moves every Go tool into its own module.

A single tools/go.mod doesn't work well once goreleaser is in it: it brings ~300 indirect dependencies and through MVS it bumps shared dependencies of golangci-lint. Separate modules keep each tool's dependency set independent.

Fixes #1961

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

GoReleaser remains excluded from automatic dependency updates, and a failed version lookup can silently fall back to an unpinned release version.

2 open issues
What changed in this PR

This PR moves GoReleaser version tracking into the tools module so Renovate can manage release-tool updates.

Changes:

  • Adds GoReleaser v2.20.2 as a tool dependency and updates the tools module’s dependency graph and Go requirement.
  • Changes the release workflow to read the GoReleaser version from the tools module instead of a hard-coded value.
File Description
tools/​go.mod Registers GoReleaser and updates tool dependencies and the Go requirement.
.github/​workflows/​release.yml Retrieves the module’s GoReleaser version for the release action.

Review effort: Balanced

Comment thread .github/workflows/release.yml Resolved
Comment thread tools/go.mod Resolved
@alexandear alexandear changed the title chore(tools): add goreleaser as a tool dependency chore: add goreleaser as a tool dependency Nov 12, 2026
@alexandear alexandear changed the title chore: add goreleaser as a tool dependency chore(tools): add goreleaser and split tools into separate modules Nov 12, 2026
@alexandear alexandear changed the title chore(tools): add goreleaser and split tools into separate modules chore: add goreleaser and split tools into separate modules Nov 12, 2026
@alexandear alexandear changed the title chore: add goreleaser and split tools into separate modules chore: split tools into separate modules Nov 12, 2026
@alexandear
alexandear requested a balanced review from Copilot November 12, 2026 18:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change to isolate Go development tools into independent modules.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the changes isolating development tools into separate modules.

No open issues 🎉

Review effort: Balanced

@alexandear
alexandear force-pushed the tools-add-goreleaser branch 2 times, most recently from 4473594 to 8759636 Compare November 12, 2026 18:54
- lint: run make tidy tidy-tools to check root and tools go.mod files
- build, lint: cache Go modules keyed on root and tools go.sum files
- lint: quote $GITHUB_OUTPUT to satisfy actionlint
Renovate updates modules referenced by Go tool directives even when they are
marked as indirect, so the pinversion.go workaround is no longer needed.

Remove the rule disabling indirect deps since Renovate disables them by default
and the rule blocked tool updates. Match the gomod 'require' depType instead of
the nonexistent 'direct' so grouping and schedule apply.
- give build, goreleaser-build and go-mod jobs distinct cache keys
- run goreleaser-action in CI instead of compiling goreleaser from source
- read tool versions with `go mod edit -json` instead of `go list -m`
- trigger Markdown lint on goimports and shfmt module changes
- document pinned goimports and shfmt installs
@alexandear
alexandear merged commit 622f9cf into revive-lint:master Nov 12, 2026
17 checks passed
@alexandear
alexandear deleted the tools-add-goreleaser branch November 12, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin goreleaser as a Go tool and give each tool its own module

2 participants