Repository navigation
refactor: replace package-level vars with simpler code - #1966
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the package-state simplification and removal of the AppFs abstraction.
No open issues 🎉
What changed in this PR
This PR simplifies package-level state in revive, addressing #1965 by replacing avoidable variables with constants or local values. It also removes the AppFs abstraction introduced in #912 and its dependencies.
Changes:
- Pass CLI settings through a local
optionsstruct and useos.Statfor config-file checks. - Replace fixed-value variables with constants and comment-prefix regular expressions with string checks.
- Remove the
aferoand indirectgolang.org/x/textdependencies.
| File | Description |
|---|---|
rule/time_date.go |
Use a fixed-size argument array and constant arity. |
rule/get_return.go |
Make the getter-prefix length a constant. |
rule/file_header.go |
Replace prefix regular expressions with strings.HasPrefix. |
rule/defer.go |
Define normalized option names as constants. |
lint/package.go |
Make boolean sentinel values constants. |
go.sum |
Remove checksums for removed dependencies. |
go.mod |
Remove afero and indirect golang.org/x/text requirements. |
cli/main.go |
Localize CLI options and usage capture; replace AppFs with os.Stat. |
Review effort: Balanced
ccoVeille
approved these changes
Nov 13, 2026
ccoVeille
left a comment
Contributor
There was a problem hiding this comment.
Depending on cli package to get this variable sounds indeed unlikely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR removes
AppFs. It was added in #912 but hasn't been used since then (see sourcegraph).Fixes #1965