Skip to content

fix/bring back all row calculations #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
revolist merged 1 commit into from
May 26, 2026
Merged

fix/bring back all row calculations #871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/components/scroll/revogr-viewport-scroll.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,7 @@ export class RevogrViewportScroll implements ElementScroll {
this.contentHeight,
this.verticalScroll?.clientHeight ?? 0,
);
const physicalContentWidth =
this.colType === 'colPinStart' || this.colType === 'colPinEnd'
? this.contentWidth
: getContentSize(
this.contentWidth,
this.horizontalScroll?.clientWidth ?? 0,
);
const physicalContentWidth = getContentSize(this.contentWidth, 0);

@chatgpt-codex-connector chatgpt-codex-connector Bot May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve pinned viewport width beyond max scroll guard

Using getContentSize(this.contentWidth, 0) here reintroduces scroll-size compression for pinned sections, because getContentSize clamps physical size to the safeContentSize limit in getScrollDimension. For colPinStart/colPinEnd (which do not horizontally scroll), this truncates the rendered pinned pane when total pinned width exceeds the guard (~15,000,000px), so part of pinned columns becomes unreachable; the previous branch avoided this by using raw contentWidth for pinned types.

Useful? React with 👍 / 👎.

return (
<Host
onWheel={this.horizontalMouseWheel}
Expand Down
Loading