Skip to content

fix/bottom pin position update#880

Merged
revolist merged 2 commits into
mainfrom
fix/bottom-pin
Jun 2, 2026
Merged

fix/bottom pin position update#880
revolist merged 2 commits into
mainfrom
fix/bottom-pin

Conversation

@revolist

@revolist revolist commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes

    • Improved vertical spacing calculations between pinned bottom rows and grid content in compact layouts.
  • Documentation

    • Enhanced E2E testing documentation with environment validation checks, build verification commands, and detailed troubleshooting guidance for startup issues.
  • Tests

    • Added test verifying correct positioning of pinned bottom rows in grids with minimal content.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 42ab374c-e4fe-480b-938a-f1776e0cfaa9

📥 Commits

Reviewing files that changed from the base of the PR and between 0c5337f and 03e6bac.

📒 Files selected for processing (5)
  • AGENTS.md
  • e2e/pinning.spec.ts
  • packages/react
  • readme/e2e.md
  • src/components/scroll/revogr-viewport-scroll.tsx

Walkthrough

This PR fixes a rendering bug where pinned-bottom rows disappear when grid body content is short. The viewport scroll component now computes physical content height conditionally: direct clamped height when content fits the viewport, or the full getContentSize calculation when it exceeds the viewport. An E2E test validates the fix, and E2E documentation is updated to guide developers on test discovery, build preflight, and troubleshooting.

Changes

Pinned-bottom row rendering fix

Layer / File(s) Summary
Scroll height calculation fix and test validation
src/components/scroll/revogr-viewport-scroll.tsx, e2e/pinning.spec.ts
The render() method now caches clientHeight once and applies direct clamped height when content fits the viewport, preventing pinned-bottom rows from being pushed out of view. Test keeps pinned bottom rows directly after short body content validates the fix by asserting rows render and the vertical gap stays within tolerance.
E2E workflow documentation and agent guidance
readme/e2e.md, AGENTS.md
Added guidance on test file locations, Playwright test discovery commands with --list and --grep, Stencil preflight build for compile error detection, Node version checks, and troubleshooting notes to distinguish environment/startup failures from assertion failures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • revolist/revogrid#871: Modifies the same src/components/scroll/revogr-viewport-scroll.tsx component's render() method to adjust scroll sizing calculations (horizontal counterpart to this PR's vertical fix).
  • revolist/revogrid#873: Updates src/components/scroll/revogr-viewport-scroll.tsx to adjust viewport/scroll sizing during resize/render cycles, directly related to scroll parameter recalculation.
  • revolist/revogrid#852: Adds Playwright coverage to e2e/pinning.spec.ts for grid pinning behavior validation, overlapping in the same pinning test suite.

Suggested labels

bug

Suggested reviewers

  • m2a2x

Poem

🐰 A scroll that was short just couldn't hold,
Pinned rows down below, lost in the fold,
Now height caches quick, and space is just right,
Bottom rows shine bright, in proper sight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main changes: fixing bottom pinned row positioning through viewport scroll height computation adjustments and E2E test validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bottom-pin
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix/bottom-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@revolist revolist merged commit fe0566a into main Jun 2, 2026
5 checks passed
@revolist revolist deleted the fix/bottom-pin branch June 2, 2026 13:47
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants