0.0.14#32
Open
revopushbot wants to merge 3 commits into
Open
Conversation
kit2o
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce
--outputDirlayout, drop Windows, and consolidate React-release validationWhy
Diff updates require a release's uploaded package to live under a folder named
CodePush— the base-bundle lookup (react-native-utils.tstakeHermesBaseBytecode) resolves the previous bundle viapath.basename(outputFolder), and binary extraction (binary-utils.ts) hardcodes aCodePush/prefix. When--outputDiris omitted we default toos.tmpdir()/CodePush(correct), but a custom--outputDircould be any name, silently breaking diff updates (the base bundle is never found, so no-base-bytecodediff is produced).This PR fails the release early with a clear message when a custom
--outputDirdoesn't satisfy that requirement, removes Windows (no longer supported), and consolidates the scattered React-release validation into one place.What changed
--outputDirvalidation--outputDirmust end in a folder namedCodePush(e.g../build/CodePush); otherwise the release fails up front with:The "--outputDir" path must end with a folder named "CodePush" (e.g. "./build/CodePush"). Received: "...".release-reactandrelease-expo.release-nativeis untouched (it nestsCodePush/internally, so its basename is irrelevant).Drop Windows support
release-reactnow accepts onlyandroid/ios.release-react/release-expohelp text incommand-parser.ts.'Platform must be either …'messages inreact-native-utils.tsto drop Windows. (OS-level Windows handling — Git Bash backslashes — is unchanged.)Consolidated validation (
command-executor.ts)validateReactReleaseCommand(command, { resolveEntryFile })that performs all up-front validation and returns the derived inputs (platform,bundleName,entryFile,projectName): platform check,--outputDircheck, React Native project check, and entry-file resolution (skipped for Expo, whoseexpo export:embedresolves its own entry point). The semver-range check stays in the chain since it needs the async-resolved app version.releaseReact/releaseExpoare now validate → set up folders → run the chain, removing the duplicated platformswitch,package.jsonblock, and entry-file logic from both.Bug fix / hardening (in the consolidation)
try/catchwrapped the field checks, so the specific "name field not set" / "not a React Native project" errors were swallowed and replaced by the generic "unable to read package.json". Thetrynow wraps only therequire, so each error surfaces correctly.dependencies?.["react-native"]so apackage.jsonwith nodependenciesreports "not a React Native project" instead of a misleading read error.Testing
npm run build(tsc) passes; lint shows only pre-existingno-unused-varswarnings, none in touched code.release-react MyApp ios --outputDir ./build/wrong→ fails immediately with theCodePushmessage.--outputDir ./build/CodePush(and trailing slash) → proceeds.--outputDir→ still uses the tempCodePushfolder.release-react MyApp windows …→ rejected withPlatform must be either "android" or "ios".