Skip to content

Fix issue #107: Skip acknowledgment prompt in non-interactive mode #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rexlunae merged 1 commit into from
Mar 20, 2026
Merged

Fix issue #107: Skip acknowledgment prompt in non-interactive mode #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/rustyclaw-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ async fn main() -> Result<()> {
#[cfg(feature = "tui")]
{
let mut secrets = open_secrets(&config)?;
run_onboard_wizard(&mut config, &mut secrets, false)?;
run_onboard_wizard(&mut config, &mut secrets, false, args.non_interactive)?;
// Optional agent setup step
let ws_dir = config.workspace_dir();
match rustyclaw_core::tools::agent_setup::exec_agent_setup(
Expand Down Expand Up @@ -659,7 +659,7 @@ async fn main() -> Result<()> {
#[cfg(feature = "tui")]
{
let mut secrets = open_secrets(&config)?;
run_onboard_wizard(&mut config, &mut secrets, _args.reset)?;
run_onboard_wizard(&mut config, &mut secrets, _args.reset, _args.non_interactive)?;
// Optional agent setup step
let ws_dir = config.workspace_dir();
match rustyclaw_core::tools::agent_setup::exec_agent_setup(
Expand Down Expand Up @@ -709,7 +709,7 @@ async fn main() -> Result<()> {
#[cfg(feature = "tui")]
{
let mut secrets = open_secrets(&config)?;
run_onboard_wizard(&mut config, &mut secrets, false)?;
run_onboard_wizard(&mut config, &mut secrets, false, false)?;
}
#[cfg(not(feature = "tui"))]
{
Expand Down
81 changes: 42 additions & 39 deletions crates/rustyclaw-tui/src/onboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ pub fn run_onboard_wizard(
config: &mut Config,
secrets: &mut SecretsManager,
reset: bool,
non_interactive: bool,
) -> Result<bool> {
let stdin = io::stdin();
let mut reader = stdin.lock();
Expand All @@ -38,48 +39,50 @@ pub fn run_onboard_wizard(
}

// ── 0. Safety acknowledgment ───────────────────────────────────
println!(
"{}",
t::warn("⚠ Important: Please read before continuing.")
);
println!();
println!(
" RustyClaw is an {}, meaning it can",
t::accent_bright("agentic coding tool")
);
println!(" read, write, and execute code on your machine on your");
println!(" behalf. Like any powerful tool, it should be used with");
println!(" care and awareness.");
println!();
println!(
" • {} and modify files in your project",
t::bold("It can create")
);
println!(" • {} commands in your terminal", t::bold("It can run"));
println!(
" • {} with external APIs using your credentials",
t::bold("It can interact")
);
println!();
println!(" Always review actions before approving them, especially");
println!(" in production environments. You are responsible for any");
println!(" changes made by the tool.");
println!();

let ack = prompt_line(
&mut reader,
&format!(
"{} ",
t::accent("Do you acknowledge and wish to continue? [y/N]:")
),
)?;
if !ack.trim().eq_ignore_ascii_case("y") {
if !non_interactive {
println!(
"{}",
t::warn("⚠ Important: Please read before continuing.")
);
println!();
println!(" {}", t::muted("Onboarding cancelled."));
println!(
" RustyClaw is an {}, meaning it can",
t::accent_bright("agentic coding tool")
);
println!(" read, write, and execute code on your machine on your");
println!(" behalf. Like any powerful tool, it should be used with");
println!(" care and awareness.");
println!();
println!(
" • {} and modify files in your project",
t::bold("It can create")
);
println!(" • {} commands in your terminal", t::bold("It can run"));
println!(
" • {} with external APIs using your credentials",
t::bold("It can interact")
);
println!();
println!(" Always review actions before approving them, especially");
println!(" in production environments. You are responsible for any");
println!(" changes made by the tool.");
println!();

let ack = prompt_line(
&mut reader,
&format!(
"{} ",
t::accent("Do you acknowledge and wish to continue? [y/N]:")
),
)?;
if !ack.trim().eq_ignore_ascii_case("y") {
println!();
println!(" {}", t::muted("Onboarding cancelled."));
println!();
return Ok(false);
}
println!();
return Ok(false);
}
Comment on lines +42 to 85
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 non_interactive flag only skips the safety acknowledgment but leaves all other interactive prompts active, causing the wizard to hang

The non_interactive parameter is only checked at crates/rustyclaw-tui/src/onboard.rs:42 to skip the safety acknowledgment prompt (step 0). However, the rest of the wizard (steps 0b through 8) still calls prompt_line, prompt_secret, and arrow_select without checking non_interactive, so the wizard immediately blocks waiting for stdin at the "Agent name" prompt (crates/rustyclaw-tui/src/onboard.rs:105). This is particularly problematic because the CLI flags document non_interactive as "Run wizard without prompts" (crates/rustyclaw-cli/src/main.rs:107-108) and "Run without prompts" (crates/rustyclaw-cli/src/main.rs:199-201), and for rustyclaw setup --non-interactive the flag's presence alone triggers the wizard path (crates/rustyclaw-cli/src/main.rs:598). Users in automated/CI environments will find the process hangs indefinitely.

Prompt for agents 
The non_interactive flag in crates/rustyclaw-tui/src/onboard.rs needs to be threaded through the entire run_onboard_wizard function (not just the safety acknowledgment at line 42). When non_interactive is true, every interactive prompt should be skipped with sensible defaults:

1. Line 105: prompt_line for agent name - should use the current name or default "RustyClaw"
2. Lines 138-325: Secrets vault setup - should use auto-generated key file (no password), skip TOTP, skip SSH key
3. Lines 328-341: arrow_select for model provider - should use a default provider or the one already configured
4. Lines 350-449: Authentication prompts - should skip if credentials already exist, or fail gracefully
5. Lines 451-499: Base URL prompts - should use defaults
6. Lines 501-572: Model selection - should use default model
7. Lines 594-605: SOUL.md prompt - should use default
8. Line 623: setup_messaging - should skip
9. Line 627: setup_recommended_skills - should skip

Alternatively, consider early-returning with defaults when non_interactive is true, or passing the flag down to each helper function.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

println!();

// ── 0b. Name your agent ────────────────────────────────────────
println!("{}", t::heading("Name your agent:"));
Expand Down
114 changes: 114 additions & 0 deletions pr-description.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# Add Signal messenger support via signal-cli

Fixes #115

## Summary

This PR implements Signal Private Messenger integration for RustyClaw using the `signal-cli` external tool. This follows the CLI-based messenger approach outlined in the issue, providing a clean integration without requiring complex native Signal protocol libraries.

## Changes Made

### Core Implementation
- **`crates/rustyclaw-core/src/messengers/signal_cli.rs`**: Complete SignalCliMessenger implementation
- **`crates/rustyclaw-core/Cargo.toml`**: Added `signal-cli` feature flag
- **`crates/rustyclaw-core/src/messengers/mod.rs`**: Exported SignalCliMessenger with feature gating

### Documentation
- **`docs/signal-cli-setup.md`**: Comprehensive setup and configuration guide

## Features

✅ **Send messages** to individual phone numbers
✅ **Receive messages** with JSON parsing
✅ **Phone number normalization** to E.164 format
✅ **Media attachment support** via signal-cli
✅ **Group messaging** support (requires group IDs)
✅ **Proper error handling** with descriptive messages
✅ **Connection management** and health checks
✅ **Integration tests** for core functionality

## Prerequisites

This implementation requires:

1. **signal-cli**: Must be installed separately from https://github.com/AsamK/signal-cli
2. **Signal registration**: Phone number must be registered with Signal
3. **Configuration**: Proper setup in RustyClaw config.toml

## Configuration Example

```toml
[messengers.signal]
type = "signal-cli"
phone_number = "+1234567890"
signal_cli_path = "/usr/local/bin/signal-cli" # Optional
enabled = true
```

## Usage Example

```rust
use rustyclaw_core::messengers::{SignalCliMessenger, Messenger};

let mut messenger = SignalCliMessenger::new(
"my_signal".to_string(),
"+1234567890".to_string(),
);

messenger.initialize().await?;
let message_id = messenger.send_message("+19876543210", "Hello!").await?;
```

## Testing

Build with Signal support:
```bash
cargo build --features signal-cli
```

Run tests:
```bash
cargo test signal_cli --features signal-cli
```

## Architecture

This implementation follows the existing RustyClaw messenger pattern:
- Implements the `Messenger` trait
- Uses external process execution via `tokio::process::Command`
- Provides proper async/await support
- Includes comprehensive error handling
- Follows the feature-gated compilation model

## Limitations

- **External dependency**: Requires signal-cli installation
- **Process overhead**: Each operation spawns a signal-cli process
- **Limited native features**: Some Signal features may not be available
- **Rate limiting**: Subject to Signal's rate limits

## Backward Compatibility

This change is fully backward compatible:
- New feature is behind a feature flag (`signal-cli`)
- No changes to existing messenger APIs
- No breaking changes to configuration format
- Existing messengers remain unaffected

## Future Improvements

Potential enhancements for follow-up PRs:
- Process pooling for better performance
- Enhanced group chat management
- Better media handling and validation
- Signal sticker support
- Message reaction support

## Related Issues

- Closes #115: Messenger support with CLI-based approach
- Part of the two-tier messenger strategy discussed in #115

---

**Review Notes**: This implementation provides a solid foundation for Signal messaging in RustyClaw while maintaining the project's architectural principles. The CLI-based approach ensures reliability and easier maintenance compared to native protocol implementations.
Loading